Refactor command register to make only one call

src/index.ts

@@ -9,12 +9,6 @@ const client = new AdministratorClient({ intents: [Intents.FLAGS.GUILDS, Intents
 
 client.once("ready", async () => {
     client.application = await client.application?.fetch() ?? null;
-    if ("DEV" in process.env && process.env["DEV"] == "true") {
-        console.log("Dev mod enable");
-        await client.application?.commands.set([]);
-        for (const name in await client.guilds.fetch())
-            await (await client.guilds.fetch(name)).commands.set([]);
-    }
     await client.modules.loadAllModules();
     console.log("Started !");
 });

src/lib/Command.ts

@@ -1,15 +1,10 @@
-import {
+import {ApplicationCommandData, CommandInteraction} from "discord.js";
-    ApplicationCommand, ApplicationCommandData,
-    CommandInteraction,
-    GuildResolvable,
-} from "discord.js";
 import {Module} from "./Module";
 
 
 export abstract class Command {
     module: Module;
     data: ApplicationCommandData;
-    scope: ApplicationCommand<{ guild: GuildResolvable }> | undefined;
 
     constructor(module: Module) {
         this.module = module;
@@ -18,35 +13,11 @@ export abstract class Command {
 
     abstract execute(interaction: CommandInteraction): void;
 
-    async register() {
+    load(): any {
-        try {
-            if ("DEV" in process.env && process.env["DEV"] == "true") {
-                const devGuild = await this.module.modules.client?.guilds.fetch(process.env["DEVGUILD"] as any);
-                this.scope = await devGuild.commands.create(this.data); // ToDo: use only one call to avoid spamming the api
-            } else {
-                this.scope = await this.module.modules.client?.application?.commands.create(this.data);
-            }
 
-            console.log("Successfully registered commands " + this.scope?.name);
+    };
-        } catch (error) {
-            console.error(error);
-        }
-    }
 
-    async isRegister(): Promise<boolean> {
+    unload(): any {
-        if (this.scope)
-            return !! await this.module.modules.client?.application?.commands.fetch(this.scope.id); // ToDo: use only one call to avoid spamming the api
 
-        return false;
+    };
-    }
-
-    async load() {
-        if (!await this.isRegister())
-            await this.register();
-    }
-
-    async unload() {
-        if (await this.isRegister())
-            await this.unload();
-    }
 }

src/lib/Modules.ts

@@ -2,6 +2,7 @@ import { readdirSync } from "fs";
 import {Module} from "./Module";
 import {Command} from "./Command";
 import {AdministratorClient} from "./AdministratorClient";
+import {ApplicationCommandData, ApplicationCommandManager} from "discord.js";
 
 export class Modules {
     modules: Map<string, Module> = new Map<string, Module>();
@@ -11,11 +12,15 @@ export class Modules {
         this.client = client;
     }
     
-    async load(name: string) {
+    async load(name: string, createCommand: boolean = true) {
         try {
             const module: Module = new (require(__dirname+`/../modules/${name}`)[name])(this);
             await module.load();
             this.modules.set(name, module);
+
+            if (createCommand)
+                await this.registerCommand(module.commands.map(c => c.data));
+
             console.info(`Module ${name} loaded`)
         } catch (error) {
             console.error(`Fail to load module ${name}`);
@@ -56,7 +61,9 @@ export class Modules {
     
     async loadAllModules() {
         for (const module of await this.allModules())
-            await this.load(module.name);
+            await this.load(module.name, false);
+
+        await this.registerCommand(this.allCommands().map(c => c.data), true);
     }
     
     async unloadAllModules() {
@@ -69,12 +76,40 @@ export class Modules {
             await this.reload(module.name);
     }
 
-    getCommand(name: string): Command | null {
+    async registerCommand(data: ApplicationCommandData | ApplicationCommandData[], set: boolean = false) {
-        for (const module of Array.from(this.modules.values()))
+        if (!this.client.application) {
-            for (const command of module.commands)
+            this.client.logger.err("Fail to register command, client application is undefined !");
-                if (command.data.name == name)
+            return;
-                    return command;
+        }
 
+        let commands: ApplicationCommandManager = this.client.application.commands;
+
+        if ("DEV" in process.env && process.env["DEV"] == "true") {
+            await commands.set([]);
+            commands = (await this.client?.guilds.fetch(process.env["DEVGUILD"] as any)).commands as any;
+        }
+
+        if (Array.isArray(data))
+            if (set)
+                await commands.set(data);
+            else
+                for (const d of data)
+                    await commands.create(d);
+        else
+            if (set)
+                await commands.set([data]);
+            else
+                await commands.create(data);
+    }
+
+    allCommands() : Command[] {
+        return Array.from(this.modules.values()).map(m => m.commands).reduce((l, m) => l.concat(m));
+    }
+
+    getCommand(name: string): Command | null {
+        for (const command of this.allCommands())
+            if (command.data.name == name)
+                return command;
         return null;
     }
 }

src/modules/Music/commands/disconnect.ts

@@ -1,7 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
-import {AudioPlayerStatus} from "@discordjs/voice";
 
 
 export class DisconnectCommand extends Command {

src/modules/Music/commands/flush.ts

@@ -1,7 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
-import {AudioPlayerPausedState, AudioPlayerStatus} from "@discordjs/voice";
 
 
 export class FlushCommand extends Command {

src/modules/Music/commands/pause.ts

@@ -1,7 +1,7 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
-import {AudioPlayerPausedState, AudioPlayerStatus} from "@discordjs/voice";
+import {AudioPlayerStatus} from "@discordjs/voice";
 
 
 export class PauseCommand extends Command {

src/modules/Music/commands/play.ts

@@ -1,8 +1,8 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember, VoiceChannel} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
-import {Player} from "./Player";
+import {Player} from "../lib/Player";
-import {Track} from "./Track";
+import {Track} from "../lib/Track";
 import {entersState, VoiceConnectionStatus} from "@discordjs/voice";
 const {Constants: { ApplicationCommandOptionTypes }} = require("discord.js");
 

src/modules/Music/commands/queue.ts

@@ -1,6 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
 import {AudioPlayerStatus} from "@discordjs/voice";
 
 

src/modules/Music/commands/resume.ts

@@ -1,6 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
 import {AudioPlayerStatus} from "@discordjs/voice";
 
 

src/modules/Music/commands/skip.ts

@@ -1,6 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
 import {AudioPlayerStatus} from "@discordjs/voice";
 
 

src/modules/Music/commands/stop.ts

@@ -1,6 +1,6 @@
-import {Command} from "../../lib/Command";
+import {Command} from "../../../lib/Command";
 import {ChatInputApplicationCommandData, CommandInteraction, GuildMember} from "discord.js";
-import {Music} from "./index";
+import {Music} from "../index";
 import {AudioPlayerStatus} from "@discordjs/voice";