From 8a7a137def6d9bcaea0cce33c74d52c820d26377 Mon Sep 17 00:00:00 2001
From: flifloo <flifloo@gmail.com>
Date: Sat, 30 May 2020 15:42:04 +0200
Subject: [PATCH] Setup user creation and user suggestion on commands

---
 models/user.js                 |   3 +-
 public/javascripts/commands.js | 125 ++++++++++++++++++++-------------
 sockets/addUser.js             |  27 +++++++
 sockets/index.js               |  24 ++++---
 sockets/listUser.js            |  17 +++++
 5 files changed, 136 insertions(+), 60 deletions(-)
 create mode 100644 sockets/addUser.js
 create mode 100644 sockets/listUser.js

diff --git a/models/user.js b/models/user.js
index de2f0ca..39fdcd1 100644
--- a/models/user.js
+++ b/models/user.js
@@ -3,8 +3,7 @@ module.exports = (sequelize, DataTypes) => {
   const User = sequelize.define('User', {
     username: {
       type: DataTypes.STRING,
-      allowNull: false,
-      unique: true
+      primaryKey: true
     },
     passwordHash: {
       type: DataTypes.STRING
diff --git a/public/javascripts/commands.js b/public/javascripts/commands.js
index 4f115f1..b1e75d1 100644
--- a/public/javascripts/commands.js
+++ b/public/javascripts/commands.js
@@ -126,6 +126,7 @@ function radioCheck (e) {
 }
 
 function checkCheck(e, l) {
+    //ToDo setup dynamic maxSauces and maxIngredients from db !
     if (e.checked)
         current[e.name].push(e.id.replace(e.name, ""));
     else
@@ -186,6 +187,49 @@ function price() {
     return p;
 }
 
+function addUser() {
+    let firstName, lastName;
+    do {
+        firstName = prompt("First name");
+    } while (firstName === "");
+    if (firstName) {
+        do {
+            lastName = prompt("Last name");
+        } while (lastName === "");
+        if (lastName)
+            socket.emit("add user", {username: current.client, firstName: firstName, lastName: lastName});
+    }
+    if (!firstName|| !lastName) {
+        alert("User creation aborted");
+    }
+}
+
+function addCommand() {
+    current.pc = null;
+    current.price = price();
+    socket.emit("add command", current);
+    clearSelections();
+}
+
+function clearSelections() {
+    current = {dish: null, ingredient: [], sauce: [], drink: null, dessert: null, price: {}};
+    document.querySelectorAll("input[name=dish],input[name=drink],input[name=dessert]").forEach( e => {
+        e.checked = false;
+    });
+    document.querySelectorAll("input[name=ingredient],input[name=sauce]").forEach( e => {
+        e.checked = false;
+        e.disabled = true;
+    });
+    document.querySelectorAll("#resume p").forEach( e => {
+        e.innerHTML = ""
+    });
+    let user = document.getElementById("user");
+    user.value = "";
+    user.style.color = "";
+    document.getElementById("user_list").innerHTML = "";
+    document.querySelector("#resume h2").innerHTML = "0€";
+}
+
 socket.on("connected", () => {
     socket.emit("list dish");
     socket.emit("list ingredient");
@@ -266,6 +310,19 @@ socket.on("list dessert", data => {
     }
 });
 
+socket.on("list user", data => {
+    let user_list = document.getElementById("user_list");
+    user_list.innerHTML = "";
+    for (let u of data)
+        user_list.insertAdjacentHTML("beforeend", `<option value="${u}">`);
+
+    let user = document.getElementById("user");
+    if (data.indexOf(user.value) === -1)
+        user.style.color = "red";
+    else
+        user.style.color = "";
+});
+
 socket.on("new command", data => {
     addCmd(data);
 });
@@ -290,63 +347,35 @@ socket.on("error command", data => {
     error(document.querySelector(`.list #cmd${data}`))
 });
 
-socket.on("error", () => {
-    alert("An error occurred :")
+socket.on("add user", data => {
+    if (data === current.client)
+        addCommand();
+});
+
+socket.on("fail add user", () => {
+    alert("User creation fail !");
+    addUser();
+});
+
+socket.on("internal error", () => {
+    alert("An error occurred !");
 })
 
 document.querySelector(".validation").addEventListener("click", ev => {
     ev.stopPropagation();
-    let user = document.getElementById("user");
-    if (!current.dish && !current.ingredient.length && !current.sauce.length && !current.drink && !current.dessert) {
+    if (!current.dish && !current.ingredient.length && !current.sauce.length && !current.drink && !current.dessert)
         alert("Empty command !");
-        return;
-    } else if (user.style.color === "red") {
-        current.firstname = prompt("Prénom");
-        current.lastname = prompt("Nom");
-    }
-
-    current.client = user.value;
-    current.pc = 0;
-    current.price = price();
-    socket.emit("add command", current);
-    current = {dish: null, ingredient: [], sauce: [], drink: null, dessert: null, price: {}};
-    document.querySelectorAll("input[name=dish],input[name=drink],input[name=dessert]").forEach( e => {
-        e.checked = false;
-    });
-    document.querySelectorAll("input[name=ingredient],input[name=sauce]").forEach( e => {
-        e.checked = false;
-        e.disabled = true;
-    });
-    document.querySelectorAll("#resume p").forEach( e => {
-        e.innerHTML = ""
-    });
-    user.value = "";
-    user.style.color = "";
-    document.getElementById("user_list").innerHTML = "";
-    document.querySelector("#resume h2").innerHTML = "0€";
+    else if (user.style.color === "red")
+        addUser();
+    else
+        addCommand();
 });
 
-document.getElementById("user").addEventListener("keyup", ev => {hinter(ev)});
-
-function hinter(ev) {
+document.getElementById("user").addEventListener("keyup", ev => {
     let input = ev.target;
     let min_characters = 0;
     if (input.value.length < min_characters)
         return;
-    socket.emit("list users", {"user": input.value});
-}
-
-socket.on("list users", data => {
-    let user_list = document.getElementById("user_list");
-    user_list.innerHTML = "";
-    for (let u of data) {
-        user_list.insertAdjacentHTML("beforeend", `<option value="${u}">`);
-    }
-
-    let user = document.getElementById("user");
-    if (data.indexOf(user.value) === -1)
-        user.style.color = "red";
-    else {
-        user.style.color = "";
-    }
+    socket.emit("list user", input.value);
+    current.client = input.value;
 });
diff --git a/sockets/addUser.js b/sockets/addUser.js
new file mode 100644
index 0000000..48cd512
--- /dev/null
+++ b/sockets/addUser.js
@@ -0,0 +1,27 @@
+const models = require("../models");
+
+module.exports = socket => {
+    return async (data) => {
+        try {
+            let u;
+            try {
+                u = await models.User.create({
+                    username: data.username,
+                    firstName: data.firstName,
+                    lastName: data.lastName
+                })
+            } catch (e) {
+                if (e instanceof models.Sequelize.ValidationError)
+                    socket.emit("fail add user")
+                else
+                    throw e;
+            }
+
+            socket.emit("add user", u.username);
+            socket.broadcast.emit("add user", u.username);
+        } catch (e) {
+            socket.emit("internal error");
+            console.error(e);
+        }
+    }
+}
diff --git a/sockets/index.js b/sockets/index.js
index 19cb7eb..60decac 100644
--- a/sockets/index.js
+++ b/sockets/index.js
@@ -1,13 +1,15 @@
-const listCommand = require("./listCommand")
-const listDish = require("./listDish")
-const listIngredient = require("./listIngredient")
-const listSauce = require("./listSauce")
-const listDrink = require("./listDrink")
-const listDessert = require("./listDessert")
-const addCommand = require("./addCommand")
-const giveCommand = require("./giveCommand")
-const errorCommand = require("./errorCommand")
-const clearCommand = require("./clearCommand")
+const listCommand = require("./listCommand");
+const listDish = require("./listDish");
+const listIngredient = require("./listIngredient");
+const listSauce = require("./listSauce");
+const listDrink = require("./listDrink");
+const listDessert = require("./listDessert");
+const listUser = require("./listUser");
+const addCommand = require("./addCommand");
+const addUSer = require("./addUser")
+const giveCommand = require("./giveCommand");
+const errorCommand = require("./errorCommand");
+const clearCommand = require("./clearCommand");
 
 module.exports = socket => {
     socket.on("list command", listCommand(socket));
@@ -17,7 +19,9 @@ module.exports = socket => {
     socket.on("list drink", listDrink(socket));
     socket.on("list dessert", listDessert(socket));
     socket.on("list dessert", listDessert(socket));
+    socket.on("list user", listUser(socket));
     socket.on("add command", addCommand(socket));
+    socket.on("add user", addUSer(socket));
     socket.on("give command", giveCommand(socket));
     socket.on("error command", errorCommand(socket));
     socket.on("clear command", clearCommand(socket));
diff --git a/sockets/listUser.js b/sockets/listUser.js
new file mode 100644
index 0000000..4183822
--- /dev/null
+++ b/sockets/listUser.js
@@ -0,0 +1,17 @@
+const models = require("../models");
+
+module.exports = socket => {
+    return async data => {
+        let users = []
+        for (let u of await models.User.findAll({
+            where: {
+                username: {
+                    [models.Sequelize.Op.like]: data + "%"
+                }
+            }
+        })) {
+            users.push(u.username);
+        }
+        socket.emit("list user", users);
+    }
+}