Fix async assertion

package-lock.json

@@ -363,6 +363,15 @@
         "type-detect": "^4.0.5"
       }
     },
+    "chai-as-promised": {
+      "version": "7.1.1",
+      "resolved": "https://registry.npmjs.org/chai-as-promised/-/chai-as-promised-7.1.1.tgz",
+      "integrity": "sha512-azL6xMoi+uxu6z4rhWQ1jbdUhOMhis2PvscD/xjLqNMkv3BPPp2JyyuTHOrf9BOosGpNQ11v6BKv/g57RXbiaA==",
+      "dev": true,
+      "requires": {
+        "check-error": "^1.0.2"
+      }
+    },
     "chalk": {
       "version": "2.4.2",
       "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz",

package.json

@@ -24,6 +24,7 @@
   },
   "devDependencies": {
     "chai": "^4.2.0",
+    "chai-as-promised": "^7.1.1",
     "mocha": "^8.1.1",
     "sqlite3": "^5.0.0",
     "supertest": "^4.0.2"

test/database.js

@@ -1,4 +1,6 @@
-let expect = require("chai").expect;
+let chai = require("chai");
+chai.use(require("chai-as-promised"));
+let expect = chai.expect;
 let wipeDatabase = require("./utils/wipeDatabase");
 
 
@@ -35,12 +37,7 @@ describe("Database Department tests", () => {
     });
     it("Department validation", async () => {
         await models.Department.create({name: "TestDepartment"});
-        try {
+        return expect(models.Department.create({name: "TestDepartment"})).to.be.rejectedWith(models.Sequelize.ValidationError);
-            await models.Department.create({name: "TestDepartment"});
-        } catch (e) {
-            if (!(e instanceof models.Sequelize.ValidationError))
-                throw e;
-        }
     });
 });
 
@@ -63,12 +60,7 @@ describe("Database Sandwich tests", () => {
     });
     it("Sandwich validation", async () => {
         await models.Sandwich.create({name: "TestSandwich", price: 1.5});
-        try {
+        return expect(models.Sandwich.create({name: "TestSandwich", price: 1.5})).to.be.rejectedWith(models.Sequelize.ValidationError);
-            await models.Sandwich.create({name: "TestSandwich", price: 1.5});
-        } catch (e) {
-            if (!(e instanceof models.Sequelize.ValidationError))
-                throw e;
-        }
     });
 });
 
@@ -113,47 +105,32 @@ describe("Database User test", () => {
             lastName: "Test",
             passwordHash: "test"});
 
-        //Username
+        return Promise.all([
-        try {
+            //Username
-            await models.User.create({
+            expect(models.User.create({
                 username: "test",
                 email: "test2@test.fr",
                 firstName: "Test2",
                 lastName: "Test2",
                 passwordHash: "test"
-            })
+            })).to.be.rejectedWith(models.Sequelize.ValidationError),
-        } catch (e) {
+            //Email
-            if (!(e instanceof models.Sequelize.ValidationError))
+            expect(models.User.create({
-                throw e;
-        }
-
-        //Email
-        try {
-            await models.User.create({
                 username: "test2",
                 email: "test@test.fr",
                 firstName: "Test2",
                 lastName: "Test2",
                 passwordHash: "test"
-            })
+            })).to.be.rejectedWith(models.Sequelize.ValidationError),
-        } catch (e) {
+            //First & last name
-            if (!(e instanceof models.Sequelize.ValidationError))
+            expect(models.User.create({
-                throw e;
-        }
-
-        //First & last name
-        try {
-            await models.User.create({
                 username: "test2",
                 email: "test2@test.fr",
                 firstName: "Test",
                 lastName: "Test",
                 passwordHash: "test"
-            })
+            })).to.be.rejectedWith(models.Sequelize.ValidationError),
-        } catch (e) {
+        ])
-            if (!(e instanceof models.Sequelize.ValidationError))
-                throw e;
-        }
     });
     it("User associations", async () => {
         let testUser = await models.User.create({